Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix systemd release workflow on main #1741

Merged

Conversation

kranurag7
Copy link
Member

we were missing permissions for this workflow. This commit fixes the same.

Purpose of PR?:

Fixes #

Does this PR introduce a breaking change?

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

we were missing permissions for this workflow. This commit fixes the
same.

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
@daemon1024
Copy link
Member

Can we check the warnings under Token Permissions in https://securityscorecards.dev/viewer/?uri=github.com/kubearmor/KubeArmor

And handle them in this PR as well?

Thanks for looking into this

@kranurag7
Copy link
Member Author

I think permissions were already set to restrictive levels via #1623

For release workflows, we will require write permissions.

@daemon1024 daemon1024 merged commit d0f8a80 into kubearmor:main Apr 27, 2024
17 checks passed
@kranurag7 kranurag7 deleted the kr/update-systemd-release-workflow branch April 27, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants