Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test scenarios #674

Merged
merged 3 commits into from
Apr 22, 2022
Merged

update test scenarios #674

merged 3 commits into from
Apr 22, 2022

Conversation

nam-jaehyun
Copy link
Collaborator

  • update test scenarios
  • update example policies with how to test each policy

Signed-off-by: Jaehyun Nam <jn@accuknox.com>
Signed-off-by: Jaehyun Nam <jn@accuknox.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #674 (e774bef) into main (bf6087f) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
+ Coverage   35.96%   35.97%   +0.01%     
==========================================
  Files          25       25              
  Lines        9018     9018              
==========================================
+ Hits         3243     3244       +1     
  Misses       5325     5325              
+ Partials      450      449       -1     
Impacted Files Coverage Δ
KubeArmor/monitor/systemMonitor.go 48.61% <0.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf6087f...e774bef. Read the comment docs.

Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, Rest LGTM 👌🏽

Side note, What do you think about adding a CI to run multiubuntu test scenario on PRs, but since this is an extended test suit it should only run if manually triggered.

getting-started/security_policy_examples.md Outdated Show resolved Hide resolved
Signed-off-by: Jaehyun Nam <jn@accuknox.com>
@nam-jaehyun
Copy link
Collaborator Author

Small nit, Rest LGTM 👌🏽

Side note, What do you think about adding a CI to run multiubuntu test scenario on PRs, but since this is an extended test suit it should only run if manually triggered.

The reason that we use github test scenarios instead of multiubuntu ones is that it takes too much time.

@nam-jaehyun nam-jaehyun merged commit 93794fe into kubearmor:main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants