Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mutation webhook controller #687

Closed
wants to merge 1 commit into from
Closed

add mutation webhook controller #687

wants to merge 1 commit into from

Conversation

achrefbensaad
Copy link
Member

Remove annotations logic from kubearmor
update ci.
Signed-off-by: Achref Ben Saadd achref9612@gmail.com

@achrefbensaad
Copy link
Member Author

need to be rebased before merge

@achrefbensaad achrefbensaad marked this pull request as ready for review May 5, 2022 06:29
@achrefbensaad
Copy link
Member Author

@nyrahul @nam-jaehyun @daemon1024 Please review this

@daemon1024 daemon1024 requested review from daemon1024, nyrahul and nam-jaehyun and removed request for daemon1024 and nyrahul May 5, 2022 06:30
@achrefbensaad
remove annotation logic & update ci
8ad72a9 
Signed-off-by: Achref Ben Saadd <achref9612@gmail.com>
@nam-jaehyun
Copy link
Collaborator

nam-jaehyun commented May 5, 2022 •
edited

  1. I'd like to still keep the code in kubeUpdate.go since the admission controller only works in the cluster where all nodes are based on ubuntu. Also, we need to test KubeArmor in a local env (e.g., make run), but the admission controller might be not in such an env.
  2. I don't get why we need to create a local registry, which increases the overall test complexity.

nam-jaehyun
nam-jaehyun requested changes May 5, 2022
View reviewed changes
Copy link
Collaborator

@nam-jaehyun nam-jaehyun left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple files are specifically updated for the admission controller, but the updated files are also used for some other purposes. We may need to think of this PR again.

@nam-jaehyun
Copy link
Collaborator

refer to #690

@achrefbensaad achrefbensaad mentioned this pull request May 15, 2022
Merged
@nam-jaehyun
Copy link
Collaborator

outdated PR. we have a separate PR for the CI update (#695).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nam-jaehyun nam-jaehyun nam-jaehyun requested changes

@daemon1024 daemon1024 daemon1024 approved these changes

@nyrahul nyrahul Awaiting requested review from nyrahul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@achrefbensaad @nam-jaehyun @daemon1024