Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] add multi runtime CI tests #739

Merged

Conversation

DelusionalOptimist
Copy link
Member

@DelusionalOptimist DelusionalOptimist commented Jun 20, 2022

Signed-off-by: Rudraksh Pareek rudraksh@accuknox.com

PR description:

  • Adds workflow for testing CRI-O in GH actions
  • Adds a matrix job for parallelly testing all runtimes in GH actions
  • Fixes the currently failing Create KubeArmor release after testing the image workflow on main
  • Lint

Needs #697 to be merged first.

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2022

Codecov Report

Merging #739 (f1012ad) into main (cd78955) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
- Coverage   39.31%   39.22%   -0.10%     
==========================================
  Files          24       24              
  Lines        8702     8702              
==========================================
- Hits         3421     3413       -8     
- Misses       4828     4835       +7     
- Partials      453      454       +1     
Impacted Files Coverage Δ
KubeArmor/monitor/logUpdate.go 67.72% <0.00%> (-3.99%) ⬇️
KubeArmor/monitor/systemMonitor.go 51.16% <0.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd78955...f1012ad. Read the comment docs.

@DelusionalOptimist DelusionalOptimist force-pushed the DelusionalOptimist/test/crio branch 4 times, most recently from 233f001 to 4773925 Compare June 24, 2022 03:43
@DelusionalOptimist DelusionalOptimist marked this pull request as ready for review June 24, 2022 03:43
Signed-off-by: Rudraksh Pareek <rudraksh@accuknox.com>
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nyrahul nyrahul merged commit e1d6818 into kubearmor:main Jun 24, 2022
@DelusionalOptimist DelusionalOptimist deleted the DelusionalOptimist/test/crio branch June 13, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants