update deployment guide with FTR changes #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rksharma95
force-pushed
the
aws-ftr-doc
branch
2 times, most recently
from
92e771b
to
1216239
Compare
rksharma95
force-pushed
the
aws-ftr-doc
branch
2 times, most recently
from
7b49c7d
to
4c7e7e0
Compare
rksharma95
force-pushed
the
aws-ftr-doc
branch
8 times, most recently
from
7d58005
to
eea818e
Compare
Ankurk99
requested changes
Oct 26, 2022
rksharma95
force-pushed
the
aws-ftr-doc
branch
2 times, most recently
from
492158c
to
729ea50
Compare
Ankurk99
requested changes
Oct 29, 2022
There was a problem hiding this comment.
Hey @rksharma95 Can you please remove the changes made in the main README.md file. We decided that we will have the "use-cases" as a part of a document and submit that separately for the FTR. These changes are adding complexity to the main README page, which we are trying to be as brief as possible.
Signed-off-by: rk <ramakant@accuknox.com>
Ankurk99
approved these changes
Oct 29, 2022
nyrahul
approved these changes
Oct 29, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #891
Signed-off-by: rk ramakant@accuknox.com