Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pull_request): add pull request template #958

Merged
merged 2 commits into from
Nov 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
44 changes: 44 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
**Purpose of PR?**:

Fixes #

**Does this PR introduce a breaking change?**

**If the changes in this PR are manually verified, list down the scenarios covered:**:

**Additional information for reviewer?** :
_Mention if this PR is part of any design or a continuation of previous PRs_


**Checklist:**
- [ ] Bug fix. Fixes #<issue number>
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
- [ ] PR Title follows the convention of `<type>(<scope>): <subject>`
- [ ] Commit has unit tests
- [ ] Commit has integration tests

<!--

The PR title message must follow convention:
`<type>(<scope>): <subject>`.

Where: <br />
- `type` is to define what type of PR is this.
Most common types are:
- `feat` - for new features, not a new feature for build script
- `fix` - for bug fixes or improvements, not a fix for build script
- `chore` - changes not related to production code
rajaSahil marked this conversation as resolved.
Show resolved Hide resolved
- `docs` - changes related to documentation
- `style` - formatting, missing semi colons, linting fix etc; no significant production code changes
rajaSahil marked this conversation as resolved.
Show resolved Hide resolved
- `test` - adding missing tests, refactoring tests; no production code change
- `refactor` - refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changes

- `scope` is a single word that best describes where the changes fit.
rajaSahil marked this conversation as resolved.
Show resolved Hide resolved
rajaSahil marked this conversation as resolved.
Show resolved Hide resolved
- feature(`monitor`,`enforcer`)
- test(`tests`, `bdd`)
- chore(`build`)
- `subject` is a single line brief description of the changes made in the pull request.

-->
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ deploygen

# contribution
.vscode
.idea

# vagrant
.vagrant
Expand Down