New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(monitor) : add debug logs #969
Conversation
Codecov Report
@@ Coverage Diff @@
## main #969 +/- ##
==========================================
- Coverage 39.12% 39.08% -0.04%
==========================================
Files 31 31
Lines 9854 9892 +38
==========================================
+ Hits 3855 3866 +11
- Misses 5492 5510 +18
- Partials 507 516 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Can you please add exit messages here also https://github.com/kubearmor/KubeArmor/blob/main/KubeArmor/monitor/systemMonitor.go#L403-L422
and DCO is failing
Signed-off-by: daemon1024 <barun.acharya@accuknox.com>
cbec9ed
to
4400914
Compare
didn't I already add? there's a single breaking point in the function. Added the log there already 🤔 |
Sorry I miss read the line number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of PR?:
Ref #964
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Confirmed lost events after reducing the Page Size.
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>