Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(monitor) : add debug logs #969

Merged
merged 1 commit into from Nov 8, 2022

Conversation

daemon1024
Copy link
Member

@daemon1024 daemon1024 commented Nov 8, 2022

Purpose of PR?:

Ref #964

Does this PR introduce a breaking change?
No

If the changes in this PR are manually verified, list down the scenarios covered::
Confirmed lost events after reducing the Page Size.

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2022

Codecov Report

Merging #969 (cbec9ed) into main (b348572) will decrease coverage by 0.03%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #969      +/-   ##
==========================================
- Coverage   39.12%   39.08%   -0.04%     
==========================================
  Files          31       31              
  Lines        9854     9892      +38     
==========================================
+ Hits         3855     3866      +11     
- Misses       5492     5510      +18     
- Partials      507      516       +9     
Impacted Files Coverage Δ
KubeArmor/monitor/systemMonitor.go 49.87% <60.00%> (+0.37%) ⬆️
KubeArmor/core/containerdHandler.go 53.18% <0.00%> (-4.50%) ⬇️
KubeArmor/monitor/logUpdate.go 66.85% <0.00%> (-2.79%) ⬇️
KubeArmor/enforcer/appArmorProfile.go 58.39% <0.00%> (+0.44%) ⬆️
KubeArmor/enforcer/appArmorEnforcer.go 48.68% <0.00%> (+0.49%) ⬆️
KubeArmor/feeder/feeder.go 53.27% <0.00%> (+0.90%) ⬆️
KubeArmor/log/logger.go 73.58% <0.00%> (+3.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@achrefbensaad achrefbensaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Can you please add exit messages here also https://github.com/kubearmor/KubeArmor/blob/main/KubeArmor/monitor/systemMonitor.go#L403-L422
and DCO is failing

Signed-off-by: daemon1024 <barun.acharya@accuknox.com>
@daemon1024
Copy link
Member Author

Can you please add exit messages here also https://github.com/kubearmor/KubeArmor/blob/main/KubeArmor/monitor/systemMonitor.go#L403-L422

didn't I already add? there's a single breaking point in the function. Added the log there already 🤔

@achrefbensaad
Copy link
Member

didn't I already add? there's a single breaking point in the function. Added the log there already 🤔

Sorry I miss read the line number.

@achrefbensaad achrefbensaad self-requested a review November 8, 2022 08:54
Copy link
Member

@achrefbensaad achrefbensaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daemon1024 daemon1024 merged commit 3ae9faa into kubearmor:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants