Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): add cross arch docker image build feature #973

Merged
merged 1 commit into from Nov 9, 2022

Conversation

achrefbensaad
Copy link
Member

@achrefbensaad achrefbensaad commented Nov 9, 2022

Purpose of PR?:
The ability to cross build images for multiple CPU architectures.

Does this PR introduce a breaking change? No

If the changes in this PR are manually verified, list down the scenarios covered::

@Ankurk99 verified that the images works fine on his Rasbery Pi

Additional information for reviewer? :

  • When add KubeArmor ARM64 support #802 is meged, we have only to add linux/arm64/v8 in push_images and compatible images for each architecture will be built
  • Stable image hash no longer equal to latest image hash due to limitations in the buildx toolkit.
  • Added automatic builds for controllers

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

Signed-off-by: Achref ben saad <achref@accuknox.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Merging #973 (98c7331) into main (7fdfe6d) will decrease coverage by 0.15%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #973      +/-   ##
==========================================
- Coverage   39.35%   39.19%   -0.16%     
==========================================
  Files          31       31              
  Lines        9843     9898      +55     
==========================================
+ Hits         3874     3880       +6     
- Misses       5461     5505      +44     
- Partials      508      513       +5     
Impacted Files Coverage Δ
KubeArmor/enforcer/appArmorTemplate.go 100.00% <ø> (ø)
KubeArmor/feeder/feeder.go 53.27% <0.00%> (+0.78%) ⬆️
KubeArmor/feeder/policyMatcher.go 41.50% <30.00%> (-0.10%) ⬇️
KubeArmor/monitor/systemMonitor.go 49.87% <60.00%> (+0.37%) ⬆️
KubeArmor/enforcer/appArmorProfile.go 58.39% <65.71%> (+0.44%) ⬆️
KubeArmor/enforcer/appArmorEnforcer.go 48.68% <100.00%> (+0.49%) ⬆️
KubeArmor/core/containerdHandler.go 57.67% <0.00%> (-11.24%) ⬇️
KubeArmor/enforcer/bpflsm/enforcer.go 0.00% <0.00%> (ø)
KubeArmor/enforcer/bpflsm/enforcer_bpfel.go 0.00% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Ankurk99 Ankurk99 merged commit ef0d8aa into kubearmor:main Nov 9, 2022
This was referenced Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants