Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): increase build timeout - rename workflow - trigger ci build & push for controllers. #979

Merged
merged 1 commit into from Nov 10, 2022

Conversation

achrefbensaad
Copy link
Member

Signed-off-by: Achref ben saad achref@accuknox.com

Purpose of PR?:

  • Increased build timeout to 60 minutes, current build take arround 38 minutes
  • Fixed the controller release workflow name
  • Added spaces in controllers comments to trigger build

Fixes #

Does this PR introduce a breaking change?

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

Signed-off-by: Achref ben saad <achref@accuknox.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

Merging #979 (05c0ff2) into main (359e36e) will decrease coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #979      +/-   ##
==========================================
- Coverage   39.48%   39.28%   -0.21%     
==========================================
  Files          31       31              
  Lines        9898     9898              
==========================================
- Hits         3908     3888      -20     
- Misses       5476     5498      +22     
+ Partials      514      512       -2     
Impacted Files Coverage Δ
KubeArmor/core/containerdHandler.go 57.67% <0.00%> (-11.24%) ⬇️
KubeArmor/monitor/processTree.go 95.69% <0.00%> (+1.07%) ⬆️
KubeArmor/core/dockerHandler.go 47.47% <0.00%> (+2.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@Ankurk99 Ankurk99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achrefbensaad achrefbensaad merged commit 76e4ef0 into kubearmor:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants