fix(enforcer): add allow redundant rules to aid conflict resolution #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We removed redundant allow rules when default posture = audit. But this breaks our conflict resolution in from source profiles which aid lenient whitelisting policies. This change will help make lenient whitelisting policies work with default posture audit. Signed-off-by: daemon1024 <barun.acharya@accuknox.com>
4 tasks
Codecov Report
@@ Coverage Diff @@
## main #986 +/- ##
=======================================
Coverage 39.05% 39.06%
=======================================
Files 31 31
Lines 9898 9918 +20
=======================================
+ Hits 3866 3874 +8
- Misses 5515 5528 +13
+ Partials 517 516 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
We removed redundant allow rules when default posture = audit. But this breaks our conflict resolution in from source profiles which aid lenient whitelisting policies.
This change will help make lenient whitelisting policies work with default posture audit.
Ref #985
If the changes in this PR are manually verified, list down the scenarios covered::
Lenient Whitelisting Test with DefaultPosture = audit
Checklist:
<type>(<scope>): <subject>