(feat) Added address ignore options #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
nyrahul
requested changes
Jul 9, 2023
| for ignore_address in "${ignore_array[@]}"; do | ||
| [[ "$line" == *"$ignore_address"* ]] && ignore=true && break | ||
| done | ||
| [[ "$ignore" == true ]] && continue |
There was a problem hiding this comment.
Lets keep a count of ignored addresses and show the count of "ignored addresses" in the final summary.
|
We need few more ways of ignoring as mentioned in #8
Also it would be better to add test framework to kubeTLS before merging this PR. Such PRs could greatly benefit from automated tests. |
nyrahul
requested changes
Jul 9, 2023
| @@ -30,14 +30,15 @@ EOF | |||
|
|
|||
| parse_cmdargs() | |||
| { | |||
| OPTS=`getopt -o f:h --long csv:,infile:,json:,help -n 'parse-options' -- "$@"` | |||
| OPTS=`getopt -o f:h --long csv:,infile:,json:,ignore:,help -n 'parse-options' -- "$@"` | |||
There was a problem hiding this comment.
the details of ignore options are not added to usage/help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the docker container. I added a
--ignoreflag which ignores addresses mentioned there when running kubetls.SUGGESTION: We can further improve this ignore function by making it have sub arguments like ignoring certain statuses like "NOCONN".