-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Enhancement) Ginkgo test framework for k8tls #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
f312896
to
09fdb74
Compare
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> put scripts inside workflows-2 Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> testing with kind cluster Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> Updated tmp path Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> setup-go to v4 Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> fixed tmp paths Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> test improvements Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> checking CI Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> checking CI-2 Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> checking CI-3 Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> checking if /tmp can be read Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> test Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> test Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> test-3 Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> Possible success Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> Possible success-2 Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> Possible success-2 Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> checking docker Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> checking docker Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> Kind cluster stuff Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> Kind cluster stuff Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> test Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> back to k3s Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> back to k3s Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> back to k3s-3 Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> runtime containerd Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
nyrahul
requested changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me. Please check the comments. Thanks
nyrahul
requested changes
Aug 19, 2023
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> using k3s action Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> reverting Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> reverting Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> Matching address Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> Updated install script Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> Updated install script Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com> Updated install script Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
nyrahul
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test framework using ginkgo, current has two cases but as more features are added, more tests can be put here.