Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(improvements): Improve the usability of karmor probe by detailing… #362

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(improvements): Improve the usability of karmor probe by detailing… #362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion probe/probe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,8 +534,9 @@ func getPostureData(probeData []KubeArmorProbeData) map[string]string {
// sudo systemctl status kubearmor
func isSystemdMode() bool {
cmd := exec.Command("systemctl", "status", "kubearmor")
_, err := cmd.CombinedOutput()
out, err := cmd.CombinedOutput()
if err != nil {
log.Println("systemctl status kubearmor cannot be executed:", string(out))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should refactor the function to return error, and use Cobra Error handler to capture the errors. That way we will not show the error incase we find KubeArmor in kubernetes

return false
}
color.Green("\nFound KubeArmor running in Systemd mode \n\n")
Expand Down