Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multile components in one OCI repo #316

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

Abirdcfly
Copy link
Member

@Abirdcfly Abirdcfly commented Aug 30, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it

we can support follow oci url after this pr merged:

  • harbor:
    • oci://demo.goharbor.io/helm-test
    • oci://demo.goharbor.io/helm-test/nginx
  • dockerhub
    • oci://registry-1.docker.io/bitnamicharts
    • oci://registry-1.docker.io/bitnamicharts/wordpress
  • github package for organization:
    • oci://ghcr.io/oci-helm-example
    • oci://ghcr.io/oci-helm-example/redis
    • oci://ghcr.io/oci-helm-example/helm-oci-example
    • oci://ghcr.io/oci-helm-example/helm-oci-example/nginx
  • github package for user:
    • oci://ghcr.io/abirdcfly
    • oci://ghcr.io/abirdcfly/redis
    • oci://ghcr.io/abirdcfly/helm-oci-example
    • oci://ghcr.io/abirdcfly/helm-oci-example/nginx

Which issue(s) this PR fixes

Fixes #298

Special notes for your reviewer

xref: kubebb/website#60

CleanShot 2023-09-04 at 18 51 42

@Abirdcfly Abirdcfly force-pushed the mulregistry branch 5 times, most recently from 455f475 to f2840c7 Compare August 31, 2023 10:35
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #316 (d2a79a3) into main (a046a7a) will increase coverage by 1.90%.
The diff coverage is 45.03%.

@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
+ Coverage   22.51%   24.42%   +1.90%     
==========================================
  Files          36       37       +1     
  Lines        3264     3529     +265     
==========================================
+ Hits          735      862     +127     
- Misses       2491     2609     +118     
- Partials       38       58      +20     
Files Changed Coverage Δ
api/v1alpha1/component.go 100.00% <ø> (ø)
controllers/componentplan_controller.go 5.43% <0.00%> (-0.10%) ⬇️
pkg/helm/cmd.go 0.00% <0.00%> (ø)
pkg/helm/helm.go 7.05% <0.00%> (+0.18%) ⬆️
pkg/helm/oci_list.go 48.63% <48.63%> (ø)
api/v1alpha1/repository.go 14.28% <100.00%> (+1.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Abirdcfly Abirdcfly force-pushed the mulregistry branch 7 times, most recently from 15f3dd6 to 6b79b8b Compare September 4, 2023 02:11
@Abirdcfly Abirdcfly changed the title [wip] feat: support multile components in one OCI repo Sep 4, 2023
@Abirdcfly Abirdcfly force-pushed the mulregistry branch 16 times, most recently from 6355516 to c68b08a Compare September 4, 2023 10:29
@Abirdcfly Abirdcfly force-pushed the mulregistry branch 5 times, most recently from d4c7141 to ed9169f Compare September 6, 2023 05:21
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
@Abirdcfly
Copy link
Member Author

@bjwswang PTAL

@bjwswang bjwswang merged commit 74b09d3 into kubebb:main Sep 6, 2023
20 checks passed
@Abirdcfly Abirdcfly deleted the mulregistry branch September 6, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support multile components in one OCI repo
3 participants