Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cpl latest should handle helm operation #391

Merged
merged 1 commit into from Nov 1, 2023

Conversation

Abirdcfly
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it

Which issue(s) this PR fixes

For #388

Special notes for your reviewer

@Abirdcfly Abirdcfly temporarily deployed to Dev October 31, 2023 10:04 — with GitHub Actions Inactive
@Abirdcfly Abirdcfly temporarily deployed to Dev October 31, 2023 10:04 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #391 (c28972a) into main (6796675) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
- Coverage   27.10%   26.94%   -0.16%     
==========================================
  Files          37       37              
  Lines        4546     4572      +26     
==========================================
  Hits         1232     1232              
- Misses       3211     3237      +26     
  Partials      103      103              
Files Coverage Δ
pkg/helm/cpl_helm.go 6.28% <0.00%> (-0.17%) ⬇️
controllers/componentplan_controller.go 4.40% <0.00%> (-0.20%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
@Abirdcfly Abirdcfly temporarily deployed to Dev October 31, 2023 10:42 — with GitHub Actions Inactive
@Abirdcfly Abirdcfly temporarily deployed to Dev October 31, 2023 10:42 — with GitHub Actions Inactive
@Abirdcfly Abirdcfly marked this pull request as ready for review October 31, 2023 14:41
@bjwswang
Copy link
Collaborator

@Abirdcfly can you provide more details ?

@bjwswang bjwswang merged commit fe6f6db into kubebb:main Nov 1, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants