-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add getPath
/objectHasPath
/objectHasPathAll
functions for access to nested objects
#342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdockerty
changed the title
feat: add
feat: add Oct 4, 2023
getAtPath
function for nested objects to kubecfg.libsonnet
getAtPath
function for nested objects
jdockerty
changed the title
feat: add
feat: add Oct 4, 2023
getAtPath
function for nested objectsgetAtPath
/hasAtPath
functions for nested objects
mkmik
reviewed
Oct 4, 2023
jdockerty
force-pushed
the
feat/get-at-path-func
branch
from
October 5, 2023 10:12
cc5e89a
to
7e59174
Compare
This reverts commit 7e59174.
mkmik
reviewed
Oct 5, 2023
This brings these functions more in line with the standard library, utilising the hidden_fields_wrapper for better readability
jdockerty
changed the title
feat: add
feat: add Oct 5, 2023
getAtPath
/hasAtPath
functions for nested objectsgetPath
/objectHasPath
/objectHasPathAll
functions for access to nested objects
mkmik
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following functions:
getPath(obj, path, default=null, inc_hidden=true)
objectHasPath(obj, path, inc_hidden=false)
objectHasPathAll(obj, path)
into the
kubecfg.libsonnet
file.This is shorthand for needing to do something which looks like this for nested objects:
This was adapted from an old jsonnet mailing list and morphed to be more inline with the standard library implementations for the respective
jsonnet
functions.