-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow Helm APIVersions Capabilities #415
Conversation
previous work enabled Helm KubeVersion. this enables APIVersions as well additionally instead of continuing to drop HelmVersions Capabilites silently, warn the user and provide the value that will be used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
@mkmik looks like there hasn't been a new version cut in a while. any idea when that will happen? looks like most of the automation is in place to potentially do that automatically on merge to main. is there a reason that hasn't been enabled? would the maintainers be interested in a PR to enable it? |
I'm not sure I understand correctly. Are you suggesting to enable the automation to release a new point release automatically for every new commit? |
(in the meantime I filed #419) |
potentially, but not necessarily i was imagining using by default the version stays the same unless you prefix the commit message with |
Does it work well when commits get merged at arbitrary orders based on the merge queue / kodiak? We also get tons of automated dependency updates (thanks to renovatebot), which I guess don't matter much but it's still worth to take that into account when deciding whether using such tool is safe. That said, I generally like the idea. One of the reasons for putting new half-assed features behind a I'd welcome a PR to help set this up! |
i have always used the my expectation is that unless those things explicitly use the in the case of mulitple commits since the last tag, it always chooses the biggest version bump. EG if you merge a branch that is all what i can do in the PR is comment out the code that would actually push a tag, so that it just reports the current version and what it thinks the next version should be. then you can just let it run for a while and observe it |
previous work enabled Helm KubeVersion. this enables APIVersions as well
additionally instead of continuing to drop HelmVersions Capabilites silently, warn the user and provide the value that will be used