Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: k8s and its components support version linkage #100

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

qinyer
Copy link
Contributor

@qinyer qinyer commented Aug 12, 2022

Signed-off-by: qinyer qy913726062@gmail.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #99

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@kubeclipper-bot kubeclipper-bot added kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes do-not-merge/release-note-label-needed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-none and removed do-not-merge/release-note-label-needed labels Aug 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #100 (f45274f) into master (9fe84df) will decrease coverage by 0.00%.
The diff coverage is 4.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   11.64%   11.64%   -0.01%     
==========================================
  Files          98       98              
  Lines       15040    15051      +11     
==========================================
+ Hits         1751     1752       +1     
- Misses      13060    13070      +10     
  Partials      229      229              
Impacted Files Coverage Δ
pkg/apis/core/v1/registry.go 0.00% <0.00%> (ø)
pkg/cli/resource/resource.go 0.75% <0.00%> (-0.01%) ⬇️
pkg/apis/core/v1/handler.go 0.38% <12.50%> (+0.04%) ⬆️

@x893675
Copy link
Collaborator

x893675 commented Aug 12, 2022

/assign x893675

@x893675
Copy link
Collaborator

x893675 commented Aug 12, 2022

/milestone v1.2.0

@kubeclipper-bot kubeclipper-bot added this to the v1.2.0 milestone Aug 12, 2022
Signed-off-by: qinyer <qy913726062@gmail.com>
@x893675
Copy link
Collaborator

x893675 commented Aug 12, 2022

/milestone v1.1.0

@kubeclipper-bot kubeclipper-bot modified the milestones: v1.2.0, v1.1.0 Aug 12, 2022
@x893675
Copy link
Collaborator

x893675 commented Aug 12, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: e6c0f8df7381af2c8e47b8bff2289a2210ed509f

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinyer, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2022
@kubeclipper-bot kubeclipper-bot merged commit ac9a4b1 into kubeclipper:master Aug 12, 2022
Xvv-v pushed a commit to Xvv-v/kubeclipper that referenced this pull request Aug 15, 2022
Signed-off-by: qinyer <qy913726062@gmail.com>

Signed-off-by: qinyer <qy913726062@gmail.com>
@qinyer qinyer deleted the feat-metadata-chart branch August 16, 2022 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metadata supports K8S and its components support version constraints
4 participants