Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add agent proxy #125

Merged
merged 6 commits into from
Aug 25, 2022
Merged

feat: add agent proxy #125

merged 6 commits into from
Aug 25, 2022

Conversation

lixd
Copy link
Contributor

@lixd lixd commented Aug 17, 2022 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

add kc-proxy to resolve network issues in edge scenarios.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

1.kc-proxy server for port forwarding
2.fix: synchronization update for proxy
  metadata add ProxyServer、ProxyAPIServer、ProxySSH
  nats server cert san add proxy.kubeclipper.io
  mq and static server address replace by proxy if specify.
  update address in kubeconfig.
3.kcctl proxy cmd for deploy proxy

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

@kubeclipper-bot kubeclipper-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none dco-signoff: yes size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 17, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #125 (9d57d46) into master (6e3615b) will increase coverage by 0.03%.
The diff coverage is 17.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   11.78%   11.82%   +0.03%     
==========================================
  Files          98      100       +2     
  Lines       15108    15204      +96     
==========================================
+ Hits         1781     1798      +17     
- Misses      13092    13171      +79     
  Partials      235      235
Impacted Files Coverage Δ
pkg/cli/deploy/deploy.go 16.28% <0.00%> (ø)
pkg/proxy/proxy.go 0.00% <0.00%> (ø)
pkg/proxy/util.go 100.00% <100.00%> (ø)

@lixd
Copy link
Contributor Author

lixd commented Aug 17, 2022

/assign @x893675

@x893675
Copy link
Collaborator

x893675 commented Aug 17, 2022

/milestone v1.2.0

@kubeclipper-bot kubeclipper-bot added this to the v1.2.0 milestone Aug 17, 2022
@qinyer
Copy link
Contributor

qinyer commented Aug 24, 2022

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 6d539047353104e36625fb6c4203ba9fd8d75372

@qinyer
Copy link
Contributor

qinyer commented Aug 24, 2022

Under the current scheme, we can independently deploy kc-agent for nodes with an unconnected network, and only need to deploy kc-proxy on a node with an unobstructed network, so that kc-proxy can proxy kc-agent with an unconnected network, so that it can communicate with kc-server. kc-server and kc-agent are imperceptible.

@kubeclipper-bot kubeclipper-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022
@lixd
feat: add agent proxy server
51b772d 
Signed-off-by: lixd <xueduan.li@gmail.com>
@lixd
fix: synchronization update for proxy
dd92207 
1.metadata add ProxyServer、ProxyAPIServer、ProxySSH
2.nats server cert san add proxy.kubeclipper.io
3.mq and static server address replace by proxy if specify.
4.update address in kubeconfig.

Signed-off-by: lixd <xueduan.li@gmail.com>
@lixd
feat: add kcctl proxy cmd to deploy proxy server
40c282d 
Signed-off-by: lixd <xueduan.li@gmail.com>
@lixd
fix: clean cmd add clean proxy.
b29c609 
Signed-off-by: lixd <xueduan.li@gmail.com>
@lixd
fix: cycle import
77bbb88 
Signed-off-by: lixd <xueduan.li@gmail.com>
@qinyer
Copy link
Contributor

qinyer commented Aug 24, 2022

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 8846a9ea1cafcfb7a27d0c9a9c0c7d1ab3e7e552

x893675
x893675 reviewed Aug 25, 2022
View reviewed changes
Makefile
@@ -17,15 +17,18 @@ deps:
CLIENT_GEN=$(shell which client-gen)
endif

.PHONY: build build-server build-agent build-cli openapi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hack/lib/golang.sh need update

x893675
x893675 reviewed Aug 25, 2022
View reviewed changes
.github/workflows/build-kc.yml Outdated
@@ -46,7 +46,7 @@ jobs:
run: |
pushd dist
tar -zcvf kc-linux-arm64.tar.gz linux_arm64/
tar -zcvf kc-linux-amd64.tar.gz kubeclipper-server kubeclipper-agent kcctl
tar -zcvf kc-linux-amd64.tar.gz linux_amd64/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when the host is linux-amd64 , build scripts don't create linux_amd64 directory

@lixd
fix: update build script
ed12440 
Signed-off-by: lixd <xueduan.li@gmail.com>
@kubeclipper-bot kubeclipper-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2022
@lixd
Copy link
Contributor Author

lixd commented Aug 25, 2022

/cc @x893675

@x893675
Copy link
Collaborator

x893675 commented Aug 25, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: d53a22d072d98429521a225592b40e249bba7b69

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2022
@kubeclipper-bot kubeclipper-bot merged commit 996fa41 into kubeclipper:master Aug 25, 2022
@lixd lixd deleted the feat_agent_proxy branch October 25, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x893675 x893675 Awaiting requested review from x893675

Assignees

@x893675 x893675

@qinyer qinyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Workloads
Status: Done
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lixd @codecov-commenter @x893675 @qinyer @kubeclipper-bot