backup / recovery and install / uninstall component e2e test #138
Conversation
Signed-off-by: Xvv-v <xu.jingwen@99cloud.net>
kubeclipper-bot
added
the
kind/feature
|
@Xvv-v: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubeclipper-bot
added
dco-signoff: yes
do-not-merge/release-note-label-needed
size/XL
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
=======================================
Coverage 11.54% 11.54%
=======================================
Files 99 99
Lines 15511 15511
=======================================
Hits 1790 1790
Misses 13486 13486
Partials 235 235
|
Signed-off-by: Xvv-v <xu.jingwen@99cloud.net>
|
/cc @x893675 |
|
/cc @lixd |
test/e2e/cluster/component.go
Outdated
| ginkgo.By(" check nfs component condition ") | ||
| // TODO: add nfs healthy condition check | ||
| err = cluster.WaitForClusterRunning(f.Client, clu.Name, f.Timeouts.ClusterInstall) | ||
| if err != nil || !(clus.Items[0].Addons[0].Name == "nfs-provisioner") { |
There was a problem hiding this comment.
panic at here：clus.Items[0].Addons[0].Name == "nfs-provisioner"
| }, | ||
| StorageType: "FS", | ||
| FsConfig: &corev1.FsConfig{ | ||
| BackupRootDir: "/tmp", |
There was a problem hiding this comment.
in Recovery user need mount NFS to this directory，maybe we can do this auto.
| ginkgo.By("Check that there are enough available nodes") | ||
| nodes, err := f.Client.ListNodes(context.TODO(), kc.Queries{ | ||
| Pagination: query.NoPagination(), | ||
| LabelSelector: "!kubeclipper.io/nodeRole", |
There was a problem hiding this comment.
suggest: replace by const,like fmt.Sprintf("!%s", common.LabelNodeRole)
|
all works except Install component. |
Signed-off-by: Xvv-v <xu.jingwen@99cloud.net>
|
/lgtm |
|
LGTM label has been added. Git tree hash: 55edc78babe97e4be9ca773035e7a335bf66eb57
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: x893675, Xvv-v The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeclipper-bot
added
the
approved
Signed-off-by: Xvv-v xu.jingwen@99cloud.net
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #61
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: