Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build tags for inject kernel parameter #142

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

x893675
Copy link
Collaborator

@x893675 x893675 commented Aug 18, 2022

Signed-off-by: x893675 x893675@icloud.com

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Use GOTAGS=xxx make build
default build with tag kc_default

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: x893675 <x893675@icloud.com>
@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 18, 2022
@x893675
Copy link
Collaborator Author

x893675 commented Aug 18, 2022

/cc @zhuzhenfan

@x893675
Copy link
Collaborator Author

x893675 commented Aug 18, 2022

/milestone v1.1.1

@kubeclipper-bot kubeclipper-bot added this to the v1.1.1 milestone Aug 18, 2022
Signed-off-by: x893675 <x893675@icloud.com>
@zhuzhenfan
Copy link
Contributor

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: e808668be38d5e351b620be0c08512b8b6bb98e8

@kubeclipper-bot kubeclipper-bot merged commit 46aa82d into kubeclipper:master Aug 18, 2022
@x893675
Copy link
Collaborator Author

x893675 commented Aug 18, 2022

/cherrypick release-1.1

@kubeclipper-bot
Copy link
Collaborator

@x893675: new pull request created: #144

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@x893675 x893675 deleted the buildtag branch September 10, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes lgtm Indicates that a PR is ready to be merged. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants