Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor build tag #158

Merged
merged 1 commit into from
Aug 26, 2022
Merged

refactor build tag #158

merged 1 commit into from
Aug 26, 2022

Conversation

x893675
Copy link
Collaborator

@x893675 x893675 commented Aug 26, 2022

Signed-off-by: x893675 x893675@icloud.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: x893675 <x893675@icloud.com>
@kubeclipper-bot kubeclipper-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none dco-signoff: yes approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 26, 2022
@x893675
Copy link
Collaborator Author

x893675 commented Aug 26, 2022

/milestone v1.1.1
/cc @lixd

@kubeclipper-bot kubeclipper-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 26, 2022
@kubeclipper-bot kubeclipper-bot added this to the v1.1.1 milestone Aug 26, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #158 (6f67138) into master (996fa41) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #158   +/-   ##
=======================================
  Coverage   12.63%   12.63%           
=======================================
  Files         103      103           
  Lines       15959    15959           
=======================================
  Hits         2016     2016           
  Misses      13698    13698           
  Partials      245      245           

Copy link
Contributor

@lixd lixd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: dddbcdf02ef6542b706efb0589d1a0ead3353751

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot merged commit 3232cf2 into kubeclipper:master Aug 26, 2022
@x893675
Copy link
Collaborator Author

x893675 commented Aug 26, 2022

/cherrypick release-1.1

@kubeclipper-bot
Copy link
Collaborator

@x893675: new pull request created: #159

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@x893675 x893675 deleted the fix-build branch September 10, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants