Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: registry cmd remove legacy files #162

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

lixd
Copy link
Contributor

@lixd lixd commented Aug 26, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

update registry cmd to remove legacy files when clean registry.

Which issue(s) this PR fixes:

Fixes #157

Special notes for reviewers:

1. remote legacy files when registry clean cmd.
2. don't remove `/var/run/docker.sock` when user don't specify  --remove-docker flag.

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: lixd <xueduan.li@gmail.com>
@kubeclipper-bot kubeclipper-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none dco-signoff: yes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 26, 2022
@x893675
Copy link
Collaborator

x893675 commented Aug 29, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: b64c2872346ea0708360bd68ec42e7d741b7e432

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2022
@x893675
Copy link
Collaborator

x893675 commented Aug 29, 2022

/cherrypick release-1.1

@kubeclipper-bot
Copy link
Collaborator

@x893675: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot
Copy link
Collaborator

@x893675: new pull request created: #164

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lixd lixd deleted the fix_registry branch October 25, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kcctl registry clean command not cleaned up
3 participants