Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kcctl resource remove unnecessary ssh parmeter. #167

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

lixd
Copy link
Contributor

@lixd lixd commented Aug 29, 2022

Signed-off-by: lixd xueduan.li@gmail.com

What type of PR is this?

/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

kcctl resource cmd remove unnecessary ssh parameter,load from deploy-config.yaml

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: lixd <xueduan.li@gmail.com>
@kubeclipper-bot kubeclipper-bot added release-note-none kind/flake Categorizes issue or PR as related to a flaky test. dco-signoff: yes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 29, 2022
@lixd
Copy link
Contributor Author

lixd commented Aug 30, 2022

/cc @qinyer

@x893675
Copy link
Collaborator

x893675 commented Sep 1, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 1defc7fa764082e57eff77b541e1d43991792559

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2022
@kubeclipper-bot kubeclipper-bot merged commit f8de096 into kubeclipper:master Sep 1, 2022
@lixd lixd deleted the fix_kcctl_resource branch October 25, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants