Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cron schedule parse and unit test (#178) #180

Merged
merged 1 commit into from
Sep 2, 2022
Merged

update cron schedule parse and unit test (#178) #180

merged 1 commit into from
Sep 2, 2022

Conversation

Metrora
Copy link
Contributor

@Metrora Metrora commented Sep 2, 2022

  • fix unit test

Signed-off-by: Liucw liu.chuwei@99cloud.net

  • update parse month-end cron schedule 2022/9/2 final.

Signed-off-by: Liucw liu.chuwei@99cloud.net

Signed-off-by: Liucw liu.chuwei@99cloud.net
Co-authored-by: Liucw liu.chuwei@99cloud.net

What type of PR is this?

/kind feature

What this PR does / why we need it:

update cron schedule parse and unit test

Which issue(s) this PR fixes:

Fixes #179

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


* fix unit test

Signed-off-by: Liucw <liu.chuwei@99cloud.net>

* update parse month-end cron schedule 2022/9/2 final.

Signed-off-by: Liucw <liu.chuwei@99cloud.net>

Signed-off-by: Liucw <liu.chuwei@99cloud.net>
Co-authored-by: Liucw <liu.chuwei@99cloud.net>
@kubeclipper-bot kubeclipper-bot added release-note-none kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 2, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #180 (e0ea25b) into release-1.1 (ae6eec9) will increase coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.1     #180      +/-   ##
===============================================
+ Coverage        11.92%   11.96%   +0.04%     
===============================================
  Files              101      101              
  Lines            15587    15582       -5     
===============================================
+ Hits              1859     1865       +6     
+ Misses           13489    13479      -10     
+ Partials           239      238       -1     
Impacted Files Coverage Δ
pkg/controller/cronbackupcontroller/controller.go 2.46% <66.66%> (+1.49%) ⬆️

@x893675
Copy link
Collaborator

x893675 commented Sep 2, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 3fb64f22d72ee024f96c61952976a96261453f48

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Metrora, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2022
@kubeclipper-bot kubeclipper-bot merged commit 8cb55e9 into kubeclipper:release-1.1 Sep 2, 2022
@Metrora Metrora deleted the cp-178-to-release branch September 2, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants