fix: create renamed template without reporting error #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubeclipper-bot
added
release-note-none
kind/bug
Signed-off-by: Liucw <liu.chuwei@99cloud.net>
x893675
reviewed
Sep 5, 2022
pkg/apis/core/v1/handler.go
Outdated
| } | ||
|
|
||
| if len(templates.Items) > 0 { | ||
| restplus.HandleInternalError(response, request, fmt.Errorf("template '%s' already exists", template.Annotations[common.AnnotationDisplayName])) |
x893675
reviewed
Sep 5, 2022
pkg/apis/core/v1/handler.go
Outdated
| response.WriteHeader(http.StatusOK) | ||
| } | ||
|
|
||
| func (h *handler) checkTemplate(ctx context.Context, name string) (bool, error) { |
x893675
reviewed
Sep 5, 2022
pkg/apis/core/v1/handler.go
Outdated
| @@ -2508,6 +2508,22 @@ func (h *handler) CreateTemplate(request *restful.Request, response *restful.Res | |||
| restplus.HandleInternalError(response, request, err) | |||
| return | |||
| } | |||
|
|
|||
| q := query.New() | |||
| q.FuzzySearch = map[string]string{ | |||
Signed-off-by: Liucw <liu.chuwei@99cloud.net>
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
- Coverage 13.04% 13.00% -0.05%
==========================================
Files 105 105
Lines 15970 16021 +51
==========================================
Hits 2084 2084
- Misses 13635 13686 +51
Partials 251 251
|
x893675
reviewed
Sep 5, 2022
pkg/apis/core/v1/registry.go
Outdated
| Required(false). | ||
| DataFormat("fieldSelector=%s=%s")). | ||
| Returns(http.StatusOK, http.StatusText(http.StatusOK), nil). | ||
| Returns(http.StatusNotFound, http.StatusText(http.StatusNotFound), nil)) |
There was a problem hiding this comment.
use http.StatusInternalServerError instead of http.StatusNotFound
Signed-off-by: Liucw <liu.chuwei@99cloud.net>
|
/lgtm |
|
LGTM label has been added. Git tree hash: 43c5045f7ec5053f285c45c62b358bb52d9b2520
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Metrora, x893675 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeclipper-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #171
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: