Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update proxy deploy cmd's untar path. #184

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

lixd
Copy link
Contributor

@lixd lixd commented Sep 2, 2022

Signed-off-by: lixd xueduan.li@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

untar kc-linux-xxx.tar.gz and mv kubeclipper-proxy to /usr/local/bin
diff arch tar package has diff layer,compatible this by tar cmd's --strip-components flag.

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: lixd <xueduan.li@gmail.com>
@kubeclipper-bot kubeclipper-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 2, 2022
@x893675
Copy link
Collaborator

x893675 commented Sep 5, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 4a13c3945c40ca06e62b3760f232e1b941e74b8b

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2022
@kubeclipper-bot kubeclipper-bot merged commit 4ddbaa3 into kubeclipper:master Sep 5, 2022
@lixd lixd deleted the fix_proxy_deploy branch October 25, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants