Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm join node failed #189

Merged
merged 3 commits into from
Sep 5, 2022
Merged

kubeadm join node failed #189

merged 3 commits into from
Sep 5, 2022

Conversation

Xvv-v
Copy link
Contributor

@Xvv-v Xvv-v commented Sep 5, 2022

Signed-off-by: Xvv-v xu.jingwen@99cloud.net

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #186

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


Signed-off-by: Xvv-v <xu.jingwen@99cloud.net>
@kubeclipper-bot
Copy link
Collaborator

@Xvv-v: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes do-not-merge/release-note-label-needed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2022

Codecov Report

Merging #189 (3c86578) into master (4ddbaa3) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   13.04%   13.00%   -0.05%     
==========================================
  Files         105      105              
  Lines       15974    16027      +53     
==========================================
  Hits         2084     2084              
- Misses      13639    13692      +53     
  Partials      251      251              
Impacted Files Coverage Δ
pkg/scheme/core/v1/k8s/kubeadm_step.go 0.00% <0.00%> (ø)
pkg/apis/core/v1/handler.go 0.33% <0.00%> (-0.01%) ⬇️
pkg/apis/core/v1/registry.go 0.00% <0.00%> (ø)

Signed-off-by: Xvv-v <xu.jingwen@99cloud.net>
@kubeclipper-bot kubeclipper-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 5, 2022
Signed-off-by: Xvv-v <xu.jingwen@99cloud.net>
@Xvv-v
Copy link
Contributor Author

Xvv-v commented Sep 5, 2022

/cc @x893675
/cc @zhuzhenfan

@zhuzhenfan
Copy link
Contributor

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: cf15a3bb831705bf96a54e5b7427df545cc989c3

@x893675
Copy link
Collaborator

x893675 commented Sep 5, 2022

/approve

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: x893675, Xvv-v

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2022
@kubeclipper-bot kubeclipper-bot merged commit b87e163 into kubeclipper:master Sep 5, 2022
@Xvv-v Xvv-v deleted the join branch September 13, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes do-not-merge/release-note-label-needed kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubeadm join node failed
5 participants