Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Recovery fs storages type nil pointer dereference #19

Merged
merged 1 commit into from
Jul 18, 2022
Merged

fix: Recovery fs storages type nil pointer dereference #19

merged 1 commit into from
Jul 18, 2022

Conversation

zhuzhenfan
Copy link
Contributor

@zhuzhenfan zhuzhenfan commented Jul 18, 2022

Signed-off-by: zhuzhenfan zhu.zhenfan@99cloud.net

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix: Recovery fs storages type nil pointer dereference

Which issue(s) this PR fixes:

Fixes #18

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: zhuzhenfan <zhu.zhenfan@99cloud.net>
@kubeclipper-bot kubeclipper-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #19 (76ab0c5) into master (4b2c821) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   11.65%   11.64%   -0.01%     
==========================================
  Files          91       91              
  Lines       13854    13855       +1     
==========================================
  Hits         1614     1614              
- Misses      12029    12031       +2     
+ Partials      211      210       -1     
Impacted Files Coverage Δ
pkg/apis/core/v1/utils.go 56.70% <75.00%> (-0.22%) ⬇️

@zhuzhenfan
Copy link
Contributor Author

/assign @x893675
/cc @Metrora

@Metrora
Copy link
Contributor

Metrora commented Jul 18, 2022

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: a23761f4b5e47e694a7328a3fe332ce1c706f945

@x893675
Copy link
Collaborator

x893675 commented Jul 18, 2022

/approve

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: x893675, zhuzhenfan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2022
@kubeclipper-bot kubeclipper-bot merged commit 741cb18 into kubeclipper:master Jul 18, 2022
@x893675 x893675 added this to the v1.1.0 milestone Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recovery fs storages type nil pointer dereference
5 participants