fix: join node's installCNI step failed.

[lixd]

Signed-off-by: lixd xueduan.li@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #192

Special notes for reviewers:

some step need latest step,s response ,so there is a check

if len(operation.Status.Conditions[i-1].Status) < 1 {
    return errors.New("unexpected error, steps node field must be valid")
 }

and will generte Status.Conditions[i-1].Status by cond.Status := make([]v1.StepStatus, len(step.Nodes))
so，if step.Nodes == nil, len(cond.Status) is 0,and will retrun error on if len(operation.Status.Conditions[i-1].Status) < 1 check.
installCNI setp caller like this:

steps, err = cn.InitStepper(&stepper.Cluster.CNI, &stepper.Cluster.Networking).InstallSteps(patchNodes, nil, true)

second args is nil.

installCNI setp like this:

func (stepper *CNIInfo) InstallSteps(allNodes, firstMasterNodes []v1.StepNode, onlyLoad bool) ([]v1.Step, error) {
        var steps []v1.Step
        bytes, err := json.Marshal(stepper)
        if err != nil {
                return nil, err
        }
        if stepper.CNI.Offline && stepper.CNI.LocalRegistry == "" {
                steps = []v1.Step{
                        {
                                ID:         strutil.GetUUID(),
                                Name:       "cniImageLoader",
                        },
                }
        // only load images for some special scenarios, such as JoinNode
        if onlyLoad {
                return steps, nil
        }
        return append(steps, v1.Step{
                ID:         strutil.GetUUID(),
                Name:       "installCNI",
                Timeout:    metav1.Duration{Duration: 1 * time.Minute},
                ErrIgnore:  false,
                RetryTimes: 1,
                Nodes:      firstMasterNodes,
                Commands: []v1.Command{
        }), nil

In installCNI step,used second args as step.Nodes,so this will omit error.

there is a onlyload check but has a mistake,if don't in if stepper.CNI.Offline && stepper.CNI.LocalRegistry == "" { it doesn't work, this pr fix it.

and if click retry,will run from next step,so it success.

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

[codecov-commenter]

Codecov Report

Merging #193 (91d172c) into master (b87e163) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #193   +/-   ##
=======================================
  Coverage   13.00%   13.00%           
=======================================
  Files         105      105           
  Lines       16026    16026           
=======================================
  Hits         2084     2084           
  Misses      13691    13691           
  Partials      251      251           

Impacted Files	Coverage Δ
pkg/scheme/core/v1/k8s/kubeadm_step.go	0.00% <0.00%> (ø)

[lixd]

/cc @qinyer

[qinyer]

/lgtm

[x893675]

/approve

[kubeclipper-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [x893675]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[qinyer]

/lgtm

[kubeclipper-bot]

LGTM label has been added.

Git tree hash: 3e8e16c6f1fe7b513ff614940e2a0010bc58a836