Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize deploy #217

Merged
merged 2 commits into from
Sep 13, 2022
Merged

optimize deploy #217

merged 2 commits into from
Sep 13, 2022

Conversation

x893675
Copy link
Collaborator

@x893675 x893675 commented Sep 13, 2022

Signed-off-by: x893675 x893675@icloud.com

What type of PR is this?

/kind optimize

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

move render server and agent config template to DeployConfig struct
copy server and agent to server resource path
add get configmap subcommand to kcctl

Does this PR introduced a user-facing change?

none

Additional documentation, usage docs, etc.:


Signed-off-by: x893675 <x893675@icloud.com>
@kubeclipper-bot kubeclipper-bot added kind/optimize release-note-none dco-signoff: yes approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 13, 2022
@x893675
Copy link
Collaborator Author

x893675 commented Sep 13, 2022

/milestone v1.2.0
/cc @lixd @zhuzhenfan

@kubeclipper-bot kubeclipper-bot added this to the v1.2.0 milestone Sep 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2022

Codecov Report

Merging #217 (84dfdd9) into master (5db005f) will decrease coverage by 0.35%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
- Coverage   12.69%   12.34%   -0.36%     
==========================================
  Files         105      105              
  Lines       16422    16337      -85     
==========================================
- Hits         2085     2016      -69     
+ Misses      14086    14081       -5     
+ Partials      251      240      -11     
Impacted Files Coverage Δ
pkg/cli/deploy/deploy.go 5.79% <0.00%> (-7.60%) ⬇️
pkg/utils/sshutils/ssh.go 0.00% <0.00%> (ø)

Signed-off-by: x893675 <x893675@icloud.com>
Copy link
Contributor

@lixd lixd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022
@lixd
Copy link
Contributor

lixd commented Sep 13, 2022

/lgtm cancel

@kubeclipper-bot kubeclipper-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022
Copy link
Contributor

@lixd lixd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: b7c6654a747a4bea0e2392bc2d9998985e80dc6f

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot merged commit ed62229 into kubeclipper:master Sep 13, 2022
@x893675 x893675 deleted the get-cm branch October 8, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/optimize lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants