Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drain istio node failed #224

Merged
merged 1 commit into from
Sep 23, 2022
Merged

fix: drain istio node failed #224

merged 1 commit into from
Sep 23, 2022

Conversation

Metrora
Copy link
Contributor

@Metrora Metrora commented Sep 19, 2022

Signed-off-by: Liucw liu.chuwei@99cloud.net

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #223

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@x893675

Signed-off-by: Liucw <liu.chuwei@99cloud.net>
@kubeclipper-bot kubeclipper-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none dco-signoff: yes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #224 (ff5fce9) into master (e2ddd1d) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
- Coverage   12.53%   12.32%   -0.21%     
==========================================
  Files         105      105              
  Lines       16048    16320     +272     
==========================================
  Hits         2012     2012              
- Misses      13797    14069     +272     
  Partials      239      239              
Impacted Files Coverage Δ
pkg/scheme/core/v1/k8s/node.go 0.37% <0.00%> (-0.01%) ⬇️
pkg/cli/deploy/deploy.go 5.74% <0.00%> (-0.06%) ⬇️
pkg/cli/utils/download.go 0.00% <0.00%> (ø)
pkg/utils/sshutils/scp.go 0.00% <0.00%> (ø)

@zhuzhenfan
Copy link
Contributor

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 55321eb2ea5af552a069ab227cef0354a4d81e91

@x893675
Copy link
Collaborator

x893675 commented Sep 23, 2022

/approve

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Metrora, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2022
@kubeclipper-bot kubeclipper-bot merged commit 013c741 into kubeclipper:master Sep 23, 2022
@Metrora Metrora deleted the dev branch September 23, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed delete node when the node installed istio
5 participants