Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deleting abnormal k8s cluster #23

Merged
merged 1 commit into from
Jul 20, 2022
Merged

fix deleting abnormal k8s cluster #23

merged 1 commit into from
Jul 20, 2022

Conversation

qinyer
Copy link
Contributor

@qinyer qinyer commented Jul 20, 2022

Signed-off-by: qinyer qy913726062@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #22

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@kubeclipper-bot
Copy link
Collaborator

@qinyer: The label(s) kind/#22 cannot be applied, because the repository doesn't have them.

In response to this:

Change-Id: I5a49e103d0dfc9f2fbfa3c9966a9b604eef63843

What type of PR is this?

/kind bug #22

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. dco-signoff: no size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 20, 2022
@qinyer
Copy link
Contributor Author

qinyer commented Jul 20, 2022

/assign @x893675

@codecov-commenter
Copy link

Codecov Report

Merging #23 (f20ab72) into master (741cb18) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   11.64%   11.64%   -0.01%     
==========================================
  Files          91       91              
  Lines       13855    13859       +4     
==========================================
  Hits         1614     1614              
- Misses      12031    12035       +4     
  Partials      210      210              
Impacted Files Coverage Δ
pkg/component/nfs/nfs.go 0.59% <0.00%> (ø)
pkg/scheme/core/v1/k8s/cluster.go 0.12% <0.00%> (ø)
pkg/scheme/core/v1/k8s/kubeadm.go 1.06% <0.00%> (+<0.01%) ⬆️
pkg/service/delivery/delivery.go 0.00% <0.00%> (ø)
pkg/utils/cmdutil/cmdutil.go 23.36% <0.00%> (-0.68%) ⬇️

@x893675
Copy link
Collaborator

x893675 commented Jul 20, 2022

/check-dco

Signed-off-by: qinyer <qy913726062@gmail.com>
@x893675
Copy link
Collaborator

x893675 commented Jul 20, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: aa2d9ea5c5781da6f44870afd75ef3a23b4b9802

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinyer, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2022
@kubeclipper-bot kubeclipper-bot merged commit ef03f92 into kubeclipper:master Jul 20, 2022
@x893675 x893675 added this to the v1.1.0 milestone Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The k8s cluster installation is abnormal, and the cluster cannot be deleted
4 participants