-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: after cluster recovery kubeproxy pod pengding #235
Conversation
Signed-off-by: zhuzhenfan <981189503@qq.com>
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
==========================================
+ Coverage 12.16% 12.21% +0.05%
==========================================
Files 105 105
Lines 16541 16516 -25
==========================================
+ Hits 2012 2018 +6
+ Misses 14290 14260 -30
+ Partials 239 238 -1
|
pkg/apis/core/v1/utils.go
Outdated
@@ -186,9 +186,14 @@ func (h *handler) parseRecoverySteps(c *v1.Cluster, b *v1.Backup, restoreDir str | |||
|
|||
names := make([]string, 0) | |||
ips := make([]string, 0) | |||
var masters []component.Node | |||
var masters, workers []component.Node | |||
for _, node := range nodeList.Items { | |||
if node.Labels[common.LabelNodeRole] != "master" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use consistent NodeRoleMaster
instead str master
Signed-off-by: zhuzhenfan <981189503@qq.com>
/lgtm |
LGTM label has been added. Git tree hash: 6165e2a42f397dc42c13c191b80f705b17904dce
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: x893675, zhuzhenfan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: zhuzhenfan 981189503@qq.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
after cluster recovery kubeproxy pod pengding
Which issue(s) this PR fixes:
Fixes #234
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.:
@x893675 @Metrora