Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go version from 1.18 to 1.19 #240

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

x893675
Copy link
Collaborator

@x893675 x893675 commented Sep 29, 2022

Signed-off-by: x893675 x893675@icloud.com

What type of PR is this?

/kind optimize
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

bump go from 1.18 to 1.19
bump golangci-lint from 1.46.2 to 1.49.0

Does this PR introduced a user-facing change?

Bump go from 1.18 to 1.19

Additional documentation, usage docs, etc.:


Signed-off-by: x893675 <x893675@icloud.com>
@kubeclipper-bot kubeclipper-bot added kind/optimize release-note dco-signoff: yes kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 29, 2022
@x893675
Copy link
Collaborator Author

x893675 commented Sep 29, 2022

/cc @lixd @qinyer

@kubeclipper-bot kubeclipper-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 29, 2022
Signed-off-by: x893675 <x893675@icloud.com>
@codecov-commenter
Copy link

Codecov Report

Merging #240 (3f59a83) into master (43f1dc3) will increase coverage by 1.03%.
The diff coverage is 8.69%.

❗ Current head 3f59a83 differs from pull request most recent head c1b7b23. Consider uploading reports for the commit c1b7b23 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
+ Coverage   12.10%   13.13%   +1.03%     
==========================================
  Files         105       98       -7     
  Lines       16675    15333    -1342     
==========================================
- Hits         2018     2014       -4     
+ Misses      14418    13080    -1338     
  Partials      239      239              
Impacted Files Coverage Δ
pkg/authentication/mfa/sms/common.go 52.00% <ø> (ø)
pkg/cli/deploy/deploy.go 5.73% <0.00%> (ø)
pkg/cli/join/join.go 0.00% <ø> (ø)
pkg/cli/resource/resource.go 0.76% <0.00%> (ø)
pkg/component/nfs/nfs.go 0.58% <ø> (ø)
pkg/scheme/core/v1/k8s/cluster.go 0.12% <0.00%> (ø)
pkg/scheme/core/v1/k8s/node.go 0.36% <ø> (ø)
pkg/scheme/types.go 70.66% <0.00%> (-0.30%) ⬇️
pkg/utils/certs/certs.go 11.76% <ø> (ø)
pkg/utils/sshutils/ssh.go 0.00% <0.00%> (ø)
... and 8 more

Copy link
Contributor

@lixd lixd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 8daff9ffe5e115952656fca8a38dba2aae456743

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot merged commit c3f5698 into kubeclipper:master Sep 29, 2022
@x893675 x893675 deleted the bump-go branch October 8, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/optimize lgtm Indicates that a PR is ready to be merged. release-note size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants