Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kcctl clean kc env file #242

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

qinyer
Copy link
Contributor

@qinyer qinyer commented Sep 30, 2022

Signed-off-by: qinyer qy913726062@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #172

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


Signed-off-by: qinyer <qy913726062@gmail.com>
@kubeclipper-bot
Copy link
Collaborator

@qinyer: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes do-not-merge/release-note-label-needed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 30, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #242 (6874af0) into master (c3f5698) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #242   +/-   ##
=======================================
  Coverage   13.12%   13.12%           
=======================================
  Files          98       98           
  Lines       15340    15340           
=======================================
  Hits         2014     2014           
  Misses      13087    13087           
  Partials      239      239           
Impacted Files Coverage Δ
pkg/cli/registry/registry.go 0.00% <0.00%> (ø)

@x893675
Copy link
Collaborator

x893675 commented Sep 30, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 9cc213b88fa4e94d80b1d58552d2229c3bed4066

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinyer, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
@kubeclipper-bot kubeclipper-bot merged commit 00137c2 into kubeclipper:master Sep 30, 2022
@qinyer qinyer deleted the fix-kcctl-clean branch November 4, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes do-not-merge/release-note-label-needed kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

did not remove /etc/kc/kc.env file when kcctl clean
4 participants