Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the default package address for AIO #247

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

qinyer
Copy link
Contributor

@qinyer qinyer commented Oct 10, 2022

Signed-off-by: qinyer qy913726062@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #219

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


Signed-off-by: qinyer <qy913726062@gmail.com>
@kubeclipper-bot
Copy link
Collaborator

@qinyer: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2022
Signed-off-by: qinyer <qy913726062@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #247 (2cbfc67) into master (fa0beb6) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   13.12%   13.12%   -0.01%     
==========================================
  Files          98       98              
  Lines       15340    15341       +1     
==========================================
  Hits         2014     2014              
- Misses      13087    13088       +1     
  Partials      239      239              
Impacted Files Coverage Δ
pkg/cli/deploy/deploy.go 5.72% <0.00%> (-0.01%) ⬇️

@qinyer
Copy link
Contributor Author

qinyer commented Oct 10, 2022

/assign @x893675

This PR may need to be merged into the release-1.2 branch

@x893675
Copy link
Collaborator

x893675 commented Oct 10, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: f0e095a04981428630e8ba8cd7da215d55369d69

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinyer, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022
@x893675
Copy link
Collaborator

x893675 commented Oct 10, 2022

/cherrypick release-1.2

@kubeclipper-bot
Copy link
Collaborator

@x893675: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot
Copy link
Collaborator

@x893675: new pull request created: #248

In response to this:

/cherrypick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qinyer qinyer deleted the fix-kcctl-deploy branch November 4, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes do-not-merge/release-note-label-needed kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The kubectl deploy package is out of sync with the kcctl version
4 participants