Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deprecated field to mark plugin be deprecated #257

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

x893675
Copy link
Collaborator

@x893675 x893675 commented Oct 13, 2022

Signed-off-by: x893675 x893675@icloud.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

Add deprecated field

Additional documentation, usage docs, etc.:


Signed-off-by: x893675 <x893675@icloud.com>
@kubeclipper-bot kubeclipper-bot added release-note kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 13, 2022
@x893675
Copy link
Collaborator Author

x893675 commented Oct 13, 2022

/cc @lixd

@kubeclipper-bot kubeclipper-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 13, 2022
@x893675
Copy link
Collaborator Author

x893675 commented Oct 13, 2022

/milestone v1.3.1

@kubeclipper-bot kubeclipper-bot added this to the v1.3.1 milestone Oct 13, 2022
Copy link
Contributor

@lixd lixd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 8f02f24b0cfc94dc6cff23e68aa24b2d8165aac4

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot merged commit 05ed664 into kubeclipper:master Oct 13, 2022
@x893675 x893675 deleted the plugin-deprecated branch November 3, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants