Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: loginRecord clean #259

Merged
merged 2 commits into from
Oct 14, 2022
Merged

feat: loginRecord clean #259

merged 2 commits into from
Oct 14, 2022

Conversation

Xvv-v
Copy link
Contributor

@Xvv-v Xvv-v commented Oct 14, 2022

Signed-off-by: xu.jingwen xu.jingwen@99cloud.net

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #258

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


Signed-off-by: xu.jingwen <xu.jingwen@99cloud.net>
@kubeclipper-bot
Copy link
Collaborator

@Xvv-v: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes do-not-merge/release-note-label-needed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 14, 2022
@Xvv-v
Copy link
Contributor Author

Xvv-v commented Oct 14, 2022

/cc @x893675

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2022

Codecov Report

Merging #259 (8e03c42) into master (17bba1d) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   13.11%   13.11%   -0.01%     
==========================================
  Files          98       98              
  Lines       15359    15364       +5     
==========================================
  Hits         2015     2015              
- Misses      13105    13110       +5     
  Partials      239      239              
Impacted Files Coverage Δ
pkg/cli/deploy/deploy.go 5.66% <0.00%> (-0.04%) ⬇️

@x893675
Copy link
Collaborator

x893675 commented Oct 14, 2022

/cc @lixd

MQ *MQ `json:"mq" yaml:"mq,omitempty"`
OpLog *OpLog `json:"opLog" yaml:"opLog,omitempty"`
ImageProxy *ImageProxy `json:"imageProxy" yaml:"imageProxy,omitempty"`
AuthenticationOpts *options.AuthenticationOptions `json:"authenticationOpts" yaml:"authenticationOpts"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename tag to authentication

Signed-off-by: xu.jingwen <xu.jingwen@99cloud.net>
Copy link
Contributor

@lixd lixd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: e7f819f8cd5a9bae0e0e1ed98ecbe7409fb4ce73

@x893675
Copy link
Collaborator

x893675 commented Oct 14, 2022

/approve

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675, Xvv-v

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2022
@kubeclipper-bot kubeclipper-bot merged commit c7f612e into kubeclipper:master Oct 14, 2022
@Xvv-v Xvv-v deleted the login branch October 21, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes do-not-merge/release-note-label-needed kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loginRecord clean
5 participants