-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: kubeadm cluster import #261
Conversation
Signed-off-by: zhuzhenfan <981189503@qq.com>
Signed-off-by: zhuzhenfan <981189503@qq.com>
|
||
// get kubeconfig from provider | ||
providerName := c.Labels[common.LabelClusterProviderName] | ||
// get kubeconfig from rancher provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove rancher form comment
if strings.Contains(err.Error(), "ssh: handshake failed") { | ||
return "ssh connect failed,please check your ssh user、password or privateKey" | ||
} | ||
if strings.Contains(err.Error(), `"status":"401","message":"must authenticate"`) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove rancher api
err check form kubeadm
url := fmt.Sprintf("http://%s:%v/kc/kubeclipper-agent", deployConfig.ServerIPs[0], deployConfig.StaticServerPort) | ||
cmdList := []string{ | ||
"systemctl stop kc-agent || true", | ||
fmt.Sprintf("wget %s -O /usr/local/bin/kubeclipper-agent", url), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace wegt to curl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Signed-off-by: zhuzhenfan <981189503@qq.com>
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
==========================================
- Coverage 13.11% 13.08% -0.03%
==========================================
Files 98 98
Lines 15364 15387 +23
==========================================
- Hits 2015 2014 -1
- Misses 13110 13133 +23
- Partials 239 240 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 43959a28b9179e0ec5faf5078ee9610dfd635839
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lixd, x893675, zhuzhenfan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: zhuzhenfan 981189503@qq.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
nerf clusters created by external kubeadm to the platform
Which issue(s) this PR fixes:
Fixes #169
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.:
@x893675 @lixd