-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: kcctl subcommand has a bug where the ssh port is 0 #263
Conversation
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
==========================================
- Coverage 13.11% 13.06% -0.05%
==========================================
Files 98 98
Lines 15364 15395 +31
==========================================
- Hits 2015 2012 -3
- Misses 13110 13142 +32
- Partials 239 241 +2
|
Signed-off-by: zhuzhenfan <981189503@qq.com>
/lgtm |
LGTM label has been added. Git tree hash: 093a962d81d82b0b0312b1c93106a99d83459476
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: x893675, zhuzhenfan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-1.2 |
@x893675: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@x893675: new pull request created: #267 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: zhuzhenfan 981189503@qq.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix the bug that the kcctl subcommand has a ssh port of 0.
Which issue(s) this PR fixes:
Fixes #262
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.:
@x893675 @Metrora