Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kcctl subcommand has a bug where the ssh port is 0 #263

Merged
merged 1 commit into from
Oct 17, 2022
Merged

fix: kcctl subcommand has a bug where the ssh port is 0 #263

merged 1 commit into from
Oct 17, 2022

Conversation

zhuzhenfan
Copy link
Contributor

Signed-off-by: zhuzhenfan 981189503@qq.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix the bug that the kcctl subcommand has a ssh port of 0.

Which issue(s) this PR fixes:

Fixes #262

Special notes for reviewers:

@x893675 @Metrora 

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@x893675 @Metrora

@kubeclipper-bot kubeclipper-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #263 (84f5c3f) into master (c7f612e) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   13.11%   13.06%   -0.05%     
==========================================
  Files          98       98              
  Lines       15364    15395      +31     
==========================================
- Hits         2015     2012       -3     
- Misses      13110    13142      +32     
- Partials      239      241       +2     
Impacted Files Coverage Δ
pkg/utils/sshutils/ssh.go 0.00% <0.00%> (ø)
pkg/utils/sshutils/ssh_v2.go 17.54% <0.00%> (-2.10%) ⬇️
pkg/apis/core/v1/schema.go 69.72% <0.00%> (-2.11%) ⬇️
pkg/apis/core/v1/utils.go 54.12% <0.00%> (-1.85%) ⬇️
pkg/apis/core/v1/handler.go 0.33% <0.00%> (-0.01%) ⬇️
pkg/scheme/core/v1/k8s/kubeadm_step.go 0.00% <0.00%> (ø)

@kubeclipper-bot kubeclipper-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2022
Signed-off-by: zhuzhenfan <981189503@qq.com>
@x893675
Copy link
Collaborator

x893675 commented Oct 17, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 093a962d81d82b0b0312b1c93106a99d83459476

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: x893675, zhuzhenfan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2022
@x893675
Copy link
Collaborator

x893675 commented Oct 17, 2022

/cherrypick release-1.2

@kubeclipper-bot
Copy link
Collaborator

@x893675: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot
Copy link
Collaborator

@x893675: new pull request created: #267

In response to this:

/cherrypick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhuzhenfan zhuzhenfan deleted the ssh-dev branch October 24, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The kcctl subcommand has a bug where the ssh port is 0
4 participants