-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: http-server start bind address update #272
Conversation
Signed-off-by: zhuzhenfan <981189503@qq.com>
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
=======================================
Coverage 13.08% 13.08%
=======================================
Files 98 98
Lines 15395 15395
=======================================
Hits 2014 2014
Misses 13141 13141
Partials 240 240 |
/milestone v1.3.1 |
The deployment process has been tested and is running properly. |
LGTM label has been added. Git tree hash: d7b412488d0077937e12d587acb80abbabebc038
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: x893675, zhuzhenfan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: zhuzhenfan 981189503@qq.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
http-server/static-file-server/controller-api start bind address update. Previously, the http server was listening to the 0.0.0.0 network segment, without listening to the network interface of the guide according to the configuration file
Which issue(s) this PR fixes:
Fixes #246
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.:
@x893675 @qinyer