Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use agentID to drain node,compatible multiple nic #275

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

lixd
Copy link
Contributor

@lixd lixd commented Oct 19, 2022

Signed-off-by: lixd xueduan.li@gmail.com

/kind bug

What type of PR is this?

What this PR does / why we need it:

bug fix,compatible multiple nic

Which issue(s) this PR fixes:

Fixes #201

Special notes for reviewers:

deploy-config add agentID field
and used kcctl drain $agentID to drain

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: lixd <xueduan.li@gmail.com>
@kubeclipper-bot kubeclipper-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #275 (7765599) into master (3080e78) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
- Coverage   13.08%   13.07%   -0.02%     
==========================================
  Files          98       98              
  Lines       15395    15407      +12     
==========================================
  Hits         2014     2014              
- Misses      13141    13153      +12     
  Partials      240      240              
Impacted Files Coverage Δ
pkg/apis/core/v1/handler.go 0.33% <ø> (ø)
pkg/apis/core/v1/utils.go 54.12% <ø> (ø)
pkg/cli/deploy/deploy.go 5.67% <0.00%> (+0.02%) ⬆️
pkg/cli/join/join.go 0.00% <0.00%> (ø)
pkg/utils/sshutils/ssh.go 0.00% <0.00%> (ø)

@lixd
Copy link
Contributor Author

lixd commented Oct 19, 2022

/assign @x893675

@x893675
Copy link
Collaborator

x893675 commented Oct 20, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 5038821c40c424d2df287b59a89a704cefa9be9d

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2022
@kubeclipper-bot kubeclipper-bot merged commit 16f0605 into kubeclipper:master Oct 20, 2022
@lixd lixd deleted the fix_drain branch October 25, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to drain node with multiple nics
4 participants