Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kcctl create cluster using the correct version of calico #276

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

qinyer
Copy link
Contributor

@qinyer qinyer commented Oct 19, 2022

Signed-off-by: qinyer qy913726062@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #274

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


Signed-off-by: qinyer <qy913726062@gmail.com>
@kubeclipper-bot
Copy link
Collaborator

@qinyer: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes do-not-merge/release-note-label-needed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #276 (66f523c) into master (e0e0cf1) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
- Coverage   13.08%   13.07%   -0.02%     
==========================================
  Files          98       98              
  Lines       15395    15408      +13     
==========================================
  Hits         2014     2014              
- Misses      13141    13154      +13     
  Partials      240      240              
Impacted Files Coverage Δ
pkg/apis/core/v1/utils.go 54.12% <0.00%> (ø)
pkg/utils/sshutils/ssh.go 0.00% <0.00%> (ø)
pkg/apis/core/v1/handler.go 0.33% <0.00%> (ø)

@x893675
Copy link
Collaborator

x893675 commented Oct 19, 2022

/cc @lixd

Copy link
Contributor

@lixd lixd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test passed

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 401aefbdc038f13909d6ae64502f601ec35dcd0d

@x893675
Copy link
Collaborator

x893675 commented Oct 19, 2022

/approve

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, qinyer, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2022
@x893675
Copy link
Collaborator

x893675 commented Oct 19, 2022

/cherrypick release-1.2

@kubeclipper-bot
Copy link
Collaborator

@x893675: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot
Copy link
Collaborator

@x893675: new pull request created: #277

In response to this:

/cherrypick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qinyer qinyer deleted the fix-calico-version branch November 4, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes do-not-merge/release-note-label-needed kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error in calico version using kcctl to create cluster
5 participants