Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing privider value from regular clusters #279

Merged
merged 3 commits into from
Oct 20, 2022
Merged

fix: removing privider value from regular clusters #279

merged 3 commits into from
Oct 20, 2022

Conversation

zhuzhenfan
Copy link
Contributor

Signed-off-by: zhuzhenfan 981189503@qq.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

The cloudprovider controller affects the regular cluster because of the extra value of "Provider" added when the regular cluster is created

Which issue(s) this PR fixes:

Fixes #278

Special notes for reviewers:

@x893675 @lixd 

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


@kubeclipper-bot
Copy link
Collaborator

@zhuzhenfan: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes do-not-merge/release-note-label-needed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 19, 2022
Signed-off-by: zhuzhenfan <981189503@qq.com>
@x893675
Copy link
Collaborator

x893675 commented Oct 20, 2022

/cc @lixd

Signed-off-by: zhuzhenfan <981189503@qq.com>
@kubeclipper-bot kubeclipper-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Merging #279 (f1c5f82) into master (7e6eb0e) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #279   +/-   ##
=======================================
  Coverage   13.07%   13.07%           
=======================================
  Files          98       98           
  Lines       15408    15407    -1     
=======================================
  Hits         2014     2014           
+ Misses      13154    13153    -1     
  Partials      240      240           
Impacted Files Coverage Δ
pkg/cli/join/join.go 0.00% <0.00%> (ø)
pkg/cli/deploy/deploy.go 5.67% <0.00%> (+0.02%) ⬆️

Copy link
Contributor

@lixd lixd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2022
@lixd
Copy link
Contributor

lixd commented Oct 20, 2022

/lgtm cancel

@kubeclipper-bot kubeclipper-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2022
Signed-off-by: zhuzhenfan <981189503@qq.com>
Copy link
Contributor

@lixd lixd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: ba52ce8e33a4ade08cb12a43fe724b656cd52921

@x893675
Copy link
Collaborator

x893675 commented Oct 20, 2022

/approve

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675, zhuzhenfan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2022
@kubeclipper-bot kubeclipper-bot merged commit 6af848f into kubeclipper:master Oct 20, 2022
@zhuzhenfan zhuzhenfan deleted the remove-priv branch October 24, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes do-not-merge/release-note-label-needed kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impact of the cloudprovider field on regular clusters
5 participants