-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: removing privider value from regular clusters #279
Conversation
@zhuzhenfan: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: zhuzhenfan <981189503@qq.com>
/cc @lixd |
Signed-off-by: zhuzhenfan <981189503@qq.com>
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
=======================================
Coverage 13.07% 13.07%
=======================================
Files 98 98
Lines 15408 15407 -1
=======================================
Hits 2014 2014
+ Misses 13154 13153 -1
Partials 240 240
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm cancel |
Signed-off-by: zhuzhenfan <981189503@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: ba52ce8e33a4ade08cb12a43fe724b656cd52921
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lixd, x893675, zhuzhenfan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: zhuzhenfan 981189503@qq.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
The cloudprovider controller affects the regular cluster because of the extra value of "Provider" added when the regular cluster is created
Which issue(s) this PR fixes:
Fixes #278
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: