Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cluster.kubeconfig field for kubectl console. #28

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

lixd
Copy link
Contributor

@lixd lixd commented Jul 21, 2022

Signed-off-by: lixd xueduan.li@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix kubectl console bug.

Which issue(s) this PR fixes:

Fixes #27

Special notes for reviewers:

add kubeconfig to etcd by cluster.kubeconfig field.
when use kubectl console,request kubeconfig from etcd and generate clientset from kubeconfig.
and remove invalid field mgr from handler.

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: lixd <xueduan.li@gmail.com>
@kubeclipper-bot kubeclipper-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none dco-signoff: yes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 21, 2022
@lixd
Copy link
Contributor Author

lixd commented Jul 21, 2022

/assign @x893675

@x893675
Copy link
Collaborator

x893675 commented Jul 21, 2022

/cc @qinyer

help review

@x893675
Copy link
Collaborator

x893675 commented Jul 22, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 487cceff79dc13387d1869233128bdfcfbebf1a5

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2022
@kubeclipper-bot kubeclipper-bot merged commit ecba03b into kubeclipper:master Jul 22, 2022
@x893675 x893675 added this to the v1.1.0 milestone Aug 10, 2022
@lixd lixd deleted the fix_kubectl branch August 12, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubectl console conn error when kubeclipper has mutil server.
3 participants