feat: login auth rate limite #291
Conversation
Signed-off-by: qinyer <qy913726062@gmail.com>
|
@qinyer: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubeclipper-bot
added
kind/feature
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
==========================================
- Coverage 13.23% 13.23% -0.01%
==========================================
Files 98 98
Lines 15212 15215 +3
==========================================
Hits 2014 2014
- Misses 12958 12961 +3
Partials 240 240
|
| @@ -30,6 +30,7 @@ import ( | |||
| ) | |||
|
|
|||
| type AuthenticationOptions struct { | |||
| AuthenticateRateLimiterEnable bool `json:"authenticateRateLimiterEnable" yaml:"authenticateRateLimiterEnable"` | |||
There was a problem hiding this comment.
AuthenticateRateLimiterEnable should removed. i don't think this field is needed.
| @@ -43,6 +44,7 @@ type AuthenticationOptions struct { | |||
|
|
|||
| func NewAuthenticateOptions() *AuthenticationOptions { | |||
| return &AuthenticationOptions{ | |||
| AuthenticateRateLimiterEnable: false, | |||
| AuthenticateRateLimiterMaxTries: 5, | |||
| AuthenticateRateLimiterDuration: time.Minute * 30, | |||
There was a problem hiding this comment.
default value change to 10m
Signed-off-by: qinyer <qy913726062@gmail.com>
|
/lgtm |
|
LGTM label has been added. Git tree hash: 2abe29371de33e9594addc5f9ed9870ae2518dec
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinyer, x893675 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeclipper-bot
added
the
approved
Signed-off-by: qinyer qy913726062@gmail.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #286
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: