-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: determine if stderr is empty #304
Conversation
Signed-off-by: zhuzhenfan <981189503@qq.com>
/cc @lixd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: a374d0df1992d130dcb61d168d7bb113e86a5d1e
|
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
=======================================
Coverage 12.97% 12.97%
=======================================
Files 99 99
Lines 15545 15545
=======================================
Hits 2017 2017
Misses 13285 13285
Partials 243 243 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lixd, x893675, zhuzhenfan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: zhuzhenfan 981189503@qq.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
issue #294 Open again
Which issue(s) this PR fixes:
Fixes #294
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.:
@x893675 @lixd