Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: importing clusters of the same name to the kc platform will over… #316

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Conversation

zhuzhenfan
Copy link
Contributor

…write each other

Signed-off-by: zhuzhenfan 981189503@qq.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

importing clusters of the same name to the kc platform will overwrite each other

Which issue(s) this PR fixes:

Fixes #315

Special notes for reviewers:

@x893675 @lixd 

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@x893675 @lixd

@kubeclipper-bot kubeclipper-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none dco-signoff: yes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

Merging #316 (a142856) into master (97687cc) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   12.96%   12.96%           
=======================================
  Files          99       99           
  Lines       15560    15560           
=======================================
  Hits         2017     2017           
  Misses      13300    13300           
  Partials      243      243           
Impacted Files Coverage Δ
pkg/apis/core/v1/handler.go 0.31% <0.00%> (ø)
pkg/apis/core/v1/utils.go 54.12% <ø> (ø)

@kubeclipper-bot kubeclipper-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2022
…write each other

Signed-off-by: zhuzhenfan <981189503@qq.com>
Copy link
Contributor

@lixd lixd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 0b87f1e9b28f15238afe64a508dc72881e3a4dca

@x893675
Copy link
Collaborator

x893675 commented Oct 31, 2022

/approve

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675, zhuzhenfan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2022
@kubeclipper-bot kubeclipper-bot merged commit 660338d into kubeclipper:master Oct 31, 2022
@zhuzhenfan zhuzhenfan deleted the import-check branch November 14, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

importing clusters of the same name to the kc platform will overwrite each other
5 participants