Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edit no description s3 backuppoint error #321

Merged
merged 1 commit into from
Nov 1, 2022
Merged

fix: edit no description s3 backuppoint error #321

merged 1 commit into from
Nov 1, 2022

Conversation

Metrora
Copy link
Contributor

@Metrora Metrora commented Nov 1, 2022

Signed-off-by: Liucw liu.chuwei@99cloud.net

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #310

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@zhuzhenfan @x893675

Signed-off-by: Liucw <liu.chuwei@99cloud.net>
@kubeclipper-bot kubeclipper-bot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes do-not-merge/release-note-label-needed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none and removed do-not-merge/release-note-label-needed labels Nov 1, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #321 (f21fb10) into master (5da53ff) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   12.96%   12.96%   -0.01%     
==========================================
  Files         102      102              
  Lines       15623    15624       +1     
==========================================
  Hits         2026     2026              
- Misses      13354    13355       +1     
  Partials      243      243              
Impacted Files Coverage Δ
pkg/apis/core/v1/handler.go 0.31% <0.00%> (-0.01%) ⬇️

@zhuzhenfan
Copy link
Contributor

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 9235a3eac1105bd6454b774e1af83c4241360b47

@x893675
Copy link
Collaborator

x893675 commented Nov 1, 2022

/approve

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Metrora, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2022
@kubeclipper-bot kubeclipper-bot merged commit 032783b into kubeclipper:master Nov 1, 2022
@Metrora Metrora deleted the dev branch November 1, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit no description s3 backuppoint error
5 participants